leo65535 commented on code in PR #674:
URL: https://github.com/apache/ratis/pull/674#discussion_r916386221
##########
pom.xml:
##########
@@ -769,6 +769,7 @@
<configuration>
<configLocation>dev-support/checkstyle.xml</configLocation>
<failOnViolation>false</failOnViolation>
+ <includeTestSourceDirectory>true</includeTestSourceDirectory>
Review Comment:
Make sense. But it's better to keep the same rules for both `source` and
`test` code. Developers will always meet the source code check style error, but
test code is ok, this is not friendly for developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]