[
https://issues.apache.org/jira/browse/RATIS-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17577436#comment-17577436
]
mingchao zhao edited comment on RATIS-1595 at 8/9/22 2:10 PM:
--------------------------------------------------------------
Hi [~szetszwo] Here we shade dropwizard.metrics can causes compatibility issues
in Ozone. I get a type conversion error when compiling Ozone using my native
thirdparty-1.0.2 and ratis-1.4.0.
!screenshot-1.png!
We use the registry.getDropWizardMetricRegistry() returns the
org.apache.ratis.thirdparty.com.codahale.metrics.MetricRegistry
in ratis RatisMetricRegistry.
I tried to change RatisDropwizardExports from MetricRegistry to shade
MetricRegistry. But I can't change its superclass
RatisDropwizardExports extends DropwizardExports, and its constructor uses
DropwizardExports‘s. DropwizardExports is in simpleclient_dropwizard.jar. We
can't change this class to use shaded MetricRegistry.
!screenshot-4.png!
was (Author: micahzhao):
Hi [~szetszwo] Here we shade dropwizard.metrics can causes compatibility issues
in Ozone. I get a type conversion error when compiling Ozone using my native
thirdparty-1.0.2 and ratis-1.4.0.
!screenshot-1.png!
We use the registry.getDropWizardMetricRegistry() returns the
org.apache.ratis.thirdparty.com.codahale.metrics.MetricRegistry
in ratis RatisMetricRegistry.
But RatisDropwizardExports extends DropwizardExports, and its constructor uses
DropwizardExports‘s. DropwizardExports is in simpleclient_dropwizard.jar. We
can't change this class to use shaded MetricRegistry.
!screenshot-4.png!
> Shade dropwizard 4.x in ratis-thirdparty
> ----------------------------------------
>
> Key: RATIS-1595
> URL: https://issues.apache.org/jira/browse/RATIS-1595
> Project: Ratis
> Issue Type: Improvement
> Components: thirdparty
> Reporter: Yaolong Liu
> Assignee: Tsz-wo Sze
> Priority: Major
> Fix For: thirdparty-1.0.1
>
> Attachments: screenshot-1.png, screenshot-4.png
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> We should shade dropwizard.metrics 4.x in ratis-thirdparty 1.0.1 so that we
> can merge RATIS-1391 to 2.3.1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
