[ 
https://issues.apache.org/jira/browse/RATIS-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580020#comment-17580020
 ] 

mingchao zhao edited comment on RATIS-1595 at 8/16/22 3:37 AM:
---------------------------------------------------------------

bq. This JIRA RATIS-1595 is not incompatible since it is just for shading. We 
don't need to revert RATIS-1595.

[~szetszwo] Yes, I just tried revert RATIS-1391 and RATIS-1601, and that's 
fine. Here is my RATIs [test 
branch|https://github.com/captainzmc/ratis/commits/branch-2-0809-tencent-release-bak],
 and compiling Ozone with this makes sense. cc. [~liuyaolong]




was (Author: micahzhao):
??This JIRA RATIS-1595 is not incompatible since it is just for shading. We 
don't need to revert RATIS-1595.??

[~szetszwo] Yes, I just tried revert RATIS-1391 and RATIS-1601, and that's 
fine. Here is my RATIs [test 
branch|https://github.com/captainzmc/ratis/commits/branch-2-0809-tencent-release-bak],
 and compiling Ozone with this makes sense. cc. [~liuyaolong]



> Shade dropwizard 4.x in ratis-thirdparty
> ----------------------------------------
>
>                 Key: RATIS-1595
>                 URL: https://issues.apache.org/jira/browse/RATIS-1595
>             Project: Ratis
>          Issue Type: Improvement
>          Components: thirdparty
>            Reporter: Yaolong Liu
>            Assignee: Tsz-wo Sze
>            Priority: Major
>             Fix For: thirdparty-1.0.1
>
>         Attachments: screenshot-1.png, screenshot-4.png
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
>  We should shade dropwizard.metrics 4.x in ratis-thirdparty 1.0.1 so that we 
> can merge RATIS-1391 to 2.3.1.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to