codings-dan commented on code in PR #732:
URL: https://github.com/apache/ratis/pull/732#discussion_r962093680
##########
ratis-metrics/src/main/java/org/apache/ratis/metrics/RatisMetricRegistry.java:
##########
@@ -33,16 +32,14 @@
public interface RatisMetricRegistry {
Timer timer(String name);
- Counter counter(String name);
+ LongCounter counter(String name);
boolean remove(String name);
<T> void gauge(String name, Supplier<Supplier<T>> gaugeSupplier);
Timer timer(String name, MetricRegistry.MetricSupplier<Timer> supplier);
- Counter counter(String name, MetricRegistry.MetricSupplier<Counter>
supplier);
Review Comment:
While I don't find any calls in ratis code, I'm not sure if removing it
directly would introduce compatibility issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
