codings-dan commented on code in PR #732:
URL: https://github.com/apache/ratis/pull/732#discussion_r962132991
##########
ratis-metrics/src/main/java/org/apache/ratis/metrics/RatisMetricRegistry.java:
##########
@@ -33,16 +32,14 @@
public interface RatisMetricRegistry {
Timer timer(String name);
- Counter counter(String name);
+ LongCounter counter(String name);
boolean remove(String name);
<T> void gauge(String name, Supplier<Supplier<T>> gaugeSupplier);
Timer timer(String name, MetricRegistry.MetricSupplier<Timer> supplier);
- Counter counter(String name, MetricRegistry.MetricSupplier<Counter>
supplier);
Review Comment:
> * There is no way to make it API compatible
Got it.
> We may consider NOT merging this to 2.4.0 for now
Sure, I also think 2.4.0 doesn't need to include RATIS-1688 related code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
