jiacheliu3 commented on code in PR #733:
URL: https://github.com/apache/ratis/pull/733#discussion_r963279518
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##########
@@ -97,14 +98,31 @@
class RaftServerImpl implements RaftServer.Division,
RaftServerProtocol, RaftServerAsynchronousProtocol,
- RaftClientProtocol, RaftClientAsynchronousProtocol{
+ RaftClientProtocol, RaftClientAsynchronousProtocol, ErrorRecorded {
private static final String CLASS_NAME =
JavaUtils.getClassSimpleName(RaftServerImpl.class);
static final String REQUEST_VOTE = CLASS_NAME + ".requestVote";
static final String APPEND_ENTRIES = CLASS_NAME + ".appendEntries";
static final String INSTALL_SNAPSHOT = CLASS_NAME + ".installSnapshot";
static final String LOG_SYNC = APPEND_ENTRIES + ".logComplete";
static final String START_LEADER_ELECTION = CLASS_NAME +
".startLeaderElection";
+ private Throwable throwable;
+
+ @Override
+ public void setError(Throwable t) {
+ throwable = t;
+ LOG.error("Server transitioning to EXCEPTION state due to", t);
+ // TODO(jiacheng): will the server keep serving or just die itself?
Review Comment:
This might be a larger question than this particular fix but, would an
`UncaughtExceptionHandler` be too specific? I imagine the application prefers
something like a pre-crash hook that's applied to all places where the
RaftServer is going to crash or be set to `EXCEPTION` lifecycle state.
I'm good with just an `UncaughtExceptionHandler` for now of course because
that's what my application needs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
