jiacheliu3 commented on code in PR #733:
URL: https://github.com/apache/ratis/pull/733#discussion_r967060922
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerProxy.java:
##########
@@ -407,6 +426,7 @@ public void close() {
try {
getServerRpc().close();
} catch(IOException ignored) {
+ // TODO(jiacheng): transition state to EXCEPTION here?
Review Comment:
FYI this logic is gone tgt with the `ErrorRecorded` interface. I no longer
have this default behavior in the `RaftServerProxy` because it now takes an
`uncaughtExceptionHandler` from the application. Is that okay? @szetszwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
