kaijchen commented on code in PR #807:
URL: https://github.com/apache/ratis/pull/807#discussion_r1092796316


##########
ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderStateImpl.java:
##########
@@ -778,6 +778,7 @@ public void onFollowerSuccessAppendEntries(FollowerInfo 
follower) {
     } else {
       eventQueue.submit(checkStagingEvent);
     }
+    server.getTransferLeadership().onFollowerAppendEntriesReply(follower);

Review Comment:
   We could remember transferee, but then we should notify leaderStateImpl when 
transferee is changed.
   
   Currently we are skipping other followers in 
`onFollowerAppendEntriesReply()` by this if statement:
   
   ```java
       if (follower.getPeer().getId().equals(transferee)) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to