szetszwo commented on code in PR #807:
URL: https://github.com/apache/ratis/pull/807#discussion_r1093201401


##########
ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderStateImpl.java:
##########
@@ -778,6 +778,7 @@ public void onFollowerSuccessAppendEntries(FollowerInfo 
follower) {
     } else {
       eventQueue.submit(checkStagingEvent);
     }
+    server.getTransferLeadership().onFollowerAppendEntriesReply(follower);

Review Comment:
   We should use `follower.getId()` instead of `follower.getPeer().getId()` as 
described in the javadoc.
   ```java
   //FollowerInfo
     /**
      * Return this follower's {@link RaftPeer}.
      * To obtain the {@link RaftPeerId}, use {@link #getId()} which is more 
efficient than this method.
      *
      * @return this follower's peer info.
      */
     RaftPeer getPeer();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to