SzyWilliam commented on code in PR #953:
URL: https://github.com/apache/ratis/pull/953#discussion_r1375644053
##########
ratis-server-api/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java:
##########
@@ -381,7 +381,7 @@ static void setPurgePreservationLogNum(RaftProperties
properties, long purgePres
}
String SEGMENT_SIZE_MAX_KEY = PREFIX + ".segment.size.max";
- SizeInBytes SEGMENT_SIZE_MAX_DEFAULT = SizeInBytes.valueOf("8MB");
+ SizeInBytes SEGMENT_SIZE_MAX_DEFAULT = SizeInBytes.valueOf("128MB");
Review Comment:
+1 for a larger segment size. However, a larger segment size may cause
heavier memory pressure, since we need to retain the open segment in memory.
Let me update the configuration docs to include this notice after the patch
being merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
