SzyWilliam commented on code in PR #953:
URL: https://github.com/apache/ratis/pull/953#discussion_r1376972528
##########
ratis-server-api/src/main/java/org/apache/ratis/server/RaftServerConfigKeys.java:
##########
@@ -381,7 +381,7 @@ static void setPurgePreservationLogNum(RaftProperties
properties, long purgePres
}
String SEGMENT_SIZE_MAX_KEY = PREFIX + ".segment.size.max";
- SizeInBytes SEGMENT_SIZE_MAX_DEFAULT = SizeInBytes.valueOf("8MB");
+ SizeInBytes SEGMENT_SIZE_MAX_DEFAULT = SizeInBytes.valueOf("128MB");
Review Comment:
+1 8MB is small. Actually I think 128MB is good. Kafka even uses 1GB as the
segment size. It's only that I did experiments earlier and found 32MB is the
optimal for IOTDB default workload. The experiments show:
* (end to end throughput) improves substantially as segmented size grow from
8MB to 32MB, slowly from 32MB to 128MB.
* The memory usage in JVM young increases as the segmented size grow, even
if we restricted the max-cached-size and max-cached-segments. It turned out to
be the open segment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
