adoroszlai commented on code in PR #977:
URL: https://github.com/apache/ratis/pull/977#discussion_r1412564865
##########
ratis-netty/src/main/java/org/apache/ratis/netty/server/DataStreamManagement.java:
##########
@@ -277,6 +278,11 @@ public Set<ClientInvocationId> remove(ChannelId channelId)
{
this.nettyServerStreamRpcMetrics = metrics;
}
+ void shutdown() {
+ requestExecutor.shutdown();
+ writeExecutor.shutdown();
Review Comment:
Should we `awaitTermination`?
(In some runs I noticed `ConnectException` as reported in HDDS-9814, but
most other runs were fine, so I assume it's timing-sensitive now.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
