szetszwo commented on code in PR #977:
URL: https://github.com/apache/ratis/pull/977#discussion_r1412868698
##########
ratis-netty/src/main/java/org/apache/ratis/netty/client/NettyClientStreamRpc.java:
##########
@@ -260,6 +266,8 @@ synchronized boolean write(DataStreamRequest request) {
synchronized boolean shouldFlush(boolean force, int countMin, SizeInBytes
bytesMin) {
if (force || count >= countMin || bytes >= bytesMin.getSize()) {
+ LOG.debug("flush: force? {}, (count, bytes)=({}, {}), min=({}, {})",
+ force, count, bytes, countMin, bytesMin);
Review Comment:
@adoroszlai , you are right -- it should flush only if `bytes > 0`. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
