szetszwo commented on PR #990: URL: https://github.com/apache/ratis/pull/990#issuecomment-1863637861
The change assume - `processClientRequest` completes before `evictCache` This is not necessarily true -- when the log can be fast but the `StateMachine` is slow, `evictCache` can happen before `processClientRequest`. Also, it needs a separated map in `RaftLogZeroCopyCleaner` to manage all the `ReferenceCountedClosable`. It is not needed since we may release the buffer when the reference count becomes zero. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
