duongkame commented on PR #1007: URL: https://github.com/apache/ratis/pull/1007#issuecomment-1885914071
> Do we really need `zeroCopyEnabled`? It seems that there are no reason disabling it. Zero-Copy may not be naturally compatible with all use cases. One edge case I found is that a StateMachine may cache LogEntry's data and use it outside the Ratis control. If zero-copy LogEntry data is cached and then used after Ratis releases the backing buffer, the JVM will crash with memory corruption. The feature should be deliberately enabled per use case. Maybe we need to update `configurations.md` too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
