duongkame commented on PR #1042: URL: https://github.com/apache/ratis/pull/1042#issuecomment-1936375703
> @duongkame , thanks a lot for working on this! Since this change is quite large and involves multiple public API classes. Let's refactor only `TransactionContext` and the work on the `RaftLog` and `StateMachine` in a separated JIRA? > > See the comments inlined and also https://issues.apache.org/jira/secure/attachment/13066614/1042_review.patch Thanks for the detailed review as always, @szetszwo . The chance in `RaftLog` is quite minimal and a direct dependency of `TransactionContext` context API changes. `StateMachine` changes are straightforward and a consequence of `TransactionContext` changes as well. Removing them would not reduce the complexity of the PR much imho. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
