duongkame commented on PR #1042: URL: https://github.com/apache/ratis/pull/1042#issuecomment-1945476818
> > The chance in RaftLog is quite minimal and a direct dependency of TransactionContext context API changes. StateMachine changes are straightforward and a consequence of TransactionContext changes as well. ... > > I don't understand the dependency -- the `TransactionContext` change is for `StateMachine` implementations. It does not seem to relate to RaftLog. > > Also, the changes are quite separate, even the changed files are different. I just have tried moving out the `TransactionContext` change by reverting the other changed files; see https://issues.apache.org/jira/secure/attachment/13066642/1042_review2.patch > > > ... Removing them would not reduce the complexity of the PR much imho. > > It is also about future maintenance. This is not a simple code change and involve public API changes. If there are bugs/incompatibility problems later on, it will be easier to fix it or revert the change. It is also easier to backport. Sure. I've moved the RaftLog changes out, to RATIS-2028. Thanks for the suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
