Re: [PR] RATIS-2177. Delete segmentLog from small to large according to logIndex [ratis]

[via GitHub]

133tosakarin commented on PR #1174:
URL: https://github.com/apache/ratis/pull/1174#issuecomment-2464836501

   > <img alt="image" width="1247" 
src="https://private-user-images.githubusercontent.com/32640567/384348847-10f9022a-6b9a-4e22-bae4-812440f592d3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzEwNjk2OTksIm5iZiI6MTczMTA2OTM5OSwicGF0aCI6Ii8zMjY0MDU2Ny8zODQzNDg4NDctMTBmOTAyMmEtNmI5YS00ZTIyLWJhZTQtODEyNDQwZjU5MmQzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDExMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMTA4VDEyMzYzOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgwMDE1MGYwZjFjMzU2ZjcyZmQ1OGViYjVmZWY1YzIzNmU2YWFjMzMyMTI5NTExMzEwMzA3OTIwNzgzZTM5YzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dyNzrqLY7MNJHGrQJOAc4cHzD9X4rR4H9Hni2O2g8ds";>
 Maybe 
   we need to adjust the order here and delete them in order from smallest to 
largest to avoid bugs altogether?
   
   these segments that will be deleted  are sorted at constructing 
TruncateSegment, so we may not need to adjust the order here. 
   
   BTW, segments are sorted in descending order  in TruncateSegments.
   
   So, in this PR, I use reverse order traversal to delete segments


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ratis.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org