szetszwo commented on code in PR #1174:
URL: https://github.com/apache/ratis/pull/1174#discussion_r1835130817
##########
ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/SegmentedRaftLogWorker.java:
##########
@@ -694,7 +695,9 @@ void execute() throws IOException {
if (segments.getToDelete() != null && segments.getToDelete().length > 0)
{
long minStart = segments.getToDelete()[0].getStartIndex();
- for (SegmentFileInfo del : segments.getToDelete()) {
+ SegmentFileInfo[] toDelete = segments.getToDelete();
+ for (int i = toDelete.length - 1; i >= 0; i--) {
+ final SegmentFileInfo del = toDelete[i];
Review Comment:
`TruncateLog` should not be changed -- it should delete from high to low.
##########
ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/SegmentedRaftLogCache.java:
##########
@@ -359,7 +359,7 @@ TruncationSegments purge(long index) {
try (AutoCloseableLock writeLock = writeLock()) {
int segmentIndex = binarySearch(index);
List<LogSegment> list = new LinkedList<>();
-
+ LOG.info("purgeLog are: {}", segments);
Review Comment:
Print also the name and the index:
```java
LOG.info("{}: purge to index {} from closed segments {}", name,
index, segments);
```
##########
ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/SegmentedRaftLogCache.java:
##########
@@ -151,8 +151,8 @@ long maxEndIndex() {
if (toTruncate != null) {
max = toTruncate.endIndex;
}
- for(SegmentFileInfo d : toDelete) {
- max = Math.max(max, d.endIndex);
+ if (toDelete != null && toDelete.length > 0) {
+ max = Math.max(max, toDelete[0].endIndex);
Review Comment:
Let's keep the origin code since it is more robust -- it does not depend on
the ordering.
##########
ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/SegmentedRaftLogCache.java:
##########
@@ -383,6 +383,7 @@ TruncationSegments purge(long index) {
list.forEach(LogSegment::evictCache);
List<SegmentFileInfo> toDelete =
list.stream().map(SegmentFileInfo::newClosedSegmentFileInfo)
.collect(Collectors.toList());
+ LOG.info("final toDelete: {}", toDelete);
Review Comment:
Print `LogSegment` instead of `SegmentFileInfo`. It is easier to read.
```java
LOG.info("{}: toDelete segment: {}", name, list);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
