symious commented on code in PR #1179:
URL: https://github.com/apache/ratis/pull/1179#discussion_r1857509262
##########
ratis-netty/src/main/java/org/apache/ratis/netty/server/DataStreamManagement.java:
##########
@@ -479,7 +485,12 @@ private void readImpl(DataStreamRequestByteBuf request,
ChannelHandlerContext ct
try {
if (exception != null) {
replyDataStreamException(server, exception, info.getRequest(),
request, ctx);
- removeDataStream(key, info);
+ }
+ if (close || exception != null) {
Review Comment:
```
else if (close) {
info.applyToRemotes(remote -> remote.out.closeAsync());
}
```
Do we need this? remotes should have done this in remote write.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
