symious commented on code in PR #1179:
URL: https://github.com/apache/ratis/pull/1179#discussion_r1864759571
##########
ratis-client/src/main/java/org/apache/ratis/client/impl/DataStreamClientImpl.java:
##########
@@ -153,6 +153,9 @@ private CompletableFuture<DataStreamReply>
combineHeader(CompletableFuture<DataS
private CompletableFuture<DataStreamReply> writeAsyncImpl(Object data,
long length, Iterable<WriteOption> options) {
if (isClosed()) {
+ if (data instanceof ByteBuf) {
+ ((ByteBuf) data).release();
+ }
Review Comment:
But here, the request is retained twice, once in "decode", once in remote
write. For release only once in finally-blocks, if so, resource will be leak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
