adoroszlai opened a new pull request, #1192: URL: https://github.com/apache/ratis/pull/1192
## What changes were proposed in this pull request? `TestRaftWithGrpc#testWithLoad` is run 3 times, twice with the same value for `raft.grpc.server.heartbeat.channel`. This happens because `testWithLoad(boolean)` no longer overrides `testWithLoad` from parent class after RATIS-1976. ``` $ mvn -am -pl :ratis-test clean test -Dtest='TestRaftWithGrpc' -Dsurefire.reportFormat=plain ... Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 174.463 s - in org.apache.ratis.grpc.TestRaftWithGrpc org.apache.ratis.grpc.TestRaftWithGrpc.testStateMachineMetrics Time elapsed: 3.415 s org.apache.ratis.grpc.TestRaftWithGrpc.testBasicAppendEntries Time elapsed: 12.339 s org.apache.ratis.grpc.TestRaftWithGrpc.testBasicAppendEntriesKillLeader Time elapsed: 11.075 s org.apache.ratis.grpc.TestRaftWithGrpc.testOldLeaderCommit Time elapsed: 5.489 s org.apache.ratis.grpc.TestRaftWithGrpc.testWithLoad Time elapsed: 39.118 s org.apache.ratis.grpc.TestRaftWithGrpc.testOldLeaderNotCommit Time elapsed: 5.974 s org.apache.ratis.grpc.TestRaftWithGrpc.testWithLoad(Boolean)[1] Time elapsed: 35.295 s org.apache.ratis.grpc.TestRaftWithGrpc.testWithLoad(Boolean)[2] Time elapsed: 31.996 s org.apache.ratis.grpc.TestRaftWithGrpc.testRequestTimeout(Boolean)[1] Time elapsed: 8.094 s org.apache.ratis.grpc.TestRaftWithGrpc.testRequestTimeout(Boolean)[2] Time elapsed: 8.178 s org.apache.ratis.grpc.TestRaftWithGrpc.testUpdateViaHeartbeat(Boolean)[1] Time elapsed: 6.718 s org.apache.ratis.grpc.TestRaftWithGrpc.testUpdateViaHeartbeat(Boolean)[2] Time elapsed: 6.675 s ``` https://issues.apache.org/jira/browse/RATIS-2219 ## How was this patch tested? ``` $ mvn -am -pl :ratis-test clean test -Dtest='TestRaftWithGrpc' -Dsurefire.reportFormat=plain ... [INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 136.215 s - in org.apache.ratis.grpc.TestRaftWithGrpc [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testStateMachineMetrics Time elapsed: 2.96 s [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testBasicAppendEntries Time elapsed: 11.725 s [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testBasicAppendEntriesKillLeader Time elapsed: 11.64 s [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testOldLeaderCommit Time elapsed: 5.784 s [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testOldLeaderNotCommit Time elapsed: 5.727 s [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testWithLoad(boolean)[1] Time elapsed: 35.745 s [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testWithLoad(boolean)[2] Time elapsed: 32.84 s [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testRequestTimeout(boolean)[1] Time elapsed: 8.183 s [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testRequestTimeout(boolean)[2] Time elapsed: 8.181 s [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testUpdateViaHeartbeat(boolean)[1] Time elapsed: 6.683 s [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testUpdateViaHeartbeat(boolean)[2] Time elapsed: 6.658 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
