adoroszlai commented on PR #1192: URL: https://github.com/apache/ratis/pull/1192#issuecomment-2558238435
On a related note, currently only the 3 methods defined in `TestRaftWithGrpc` are parameterized for the config `raft.grpc.server.heartbeat.channel`. Is this setting relevant for the test cases inherited from parent class? ``` [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testStateMachineMetrics Time elapsed: 2.96 s [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testBasicAppendEntries Time elapsed: 11.725 s [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testBasicAppendEntriesKillLeader Time elapsed: 11.64 s [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testOldLeaderCommit Time elapsed: 5.784 s [INFO] org.apache.ratis.grpc.TestRaftWithGrpc.testOldLeaderNotCommit Time elapsed: 5.727 s ``` Should we also parameterize these? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
