slfan1989 commented on code in PR #1269:
URL: https://github.com/apache/ratis/pull/1269#discussion_r2103467520
##########
ratis-server/src/test/java/org/apache/ratis/RaftTestUtil.java:
##########
@@ -479,7 +479,7 @@ static List<RaftPeer> getPeersWithPriority(List<RaftPeer>
peers, RaftPeer sugges
static RaftPeerId changeLeader(MiniRaftCluster cluster, RaftPeerId oldLeader)
throws Exception {
- return changeLeader(cluster, oldLeader, AssumptionViolatedException::new);
Review Comment:
This part needs some clarification: we've replaced
`org.junit.AssumptionViolatedException` with
`org.opentest4j.TestAbortedException`. The reason for this change is that JUnit
5 internally uses `TestAbortedException` when handling assumptions via
`org.junit.jupiter.api.Assumptions.assumeTrue`. Given this, I believe it's
appropriate to adopt `TestAbortedException` directly in our implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
