slfan1989 commented on code in PR #1269:
URL: https://github.com/apache/ratis/pull/1269#discussion_r2103727141
##########
pom.xml:
##########
@@ -433,12 +429,12 @@
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
- <version>4.3.1</version>
+ <version>${mockito.version}</version>
</dependency>
<dependency>
<groupId>org.apache.tomcat</groupId>
<artifactId>annotations-api</artifactId>
- <version>6.0.53</version>
+ <version>${tomcat.version}</version>
<scope>provided</scope>
</dependency>
Review Comment:
We have removed the dependency on Tomcat, but we currently cannot provide
the javax.annotation.Generated annotation. As a temporary workaround, we
included javax.annotation:javax.annotation-api:1.3.2. This approach is based on
the discussion in [grpc-java issue
#9179](https://github.com/grpc/grpc-java/issues/9179). According to the latest
commit ([PR #12080](https://github.com/grpc/grpc-java/pull/12080)), the issue
has been fixed and merged two days ago. It is expected to be resolved in the
next release of grpc-java.
I have an idea: we could temporarily keep the current Tomcat dependency, and
remove it after the next grpc release includes the fix. Would this approach be
feasible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
