Copilot commented on code in PR #1328:
URL: https://github.com/apache/ratis/pull/1328#discussion_r2627420002
##########
pom.xml:
##########
@@ -726,6 +726,11 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.owasp</groupId>
+ <artifactId>dependency-check-maven</artifactId>
+ <version>12.1.9</version>
Review Comment:
The indentation of the inner plugin elements (`<groupId>`, `<artifactId>`,
`<version>`) is inconsistent with other plugin declarations. These elements
should use 8 spaces of indentation instead of the current inconsistent spacing
to match the formatting of other plugins in the file.
##########
.github/workflows/vulnerability-check.yml:
##########
@@ -0,0 +1,65 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: vulnerability-check
+
+on:
+ schedule:
+ # Run at UTC 16:00 every week (CST 00:00 AM)
+ - cron: "0 16 * * 0"
+ workflow_dispatch:
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: true
+
+env:
+ MAVEN_OPTS: -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
-Dmaven.wagon.http.retryHandler.class=standard
-Dmaven.wagon.http.retryHandler.count=3
+ MAVEN_ARGS: --batch-mode --no-transfer-progress
+
+jobs:
+ dependency-check:
+ if: ${{ github.event_name == 'workflow_dispatch' || github.repository ==
'apache/ratis' }}
+ runs-on: ubuntu-latest
+
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Set up JDK 11
+ uses: actions/setup-java@v4
+ with:
+ distribution: corretto
+ java-version: 11
+
+ - name: Do Maven install
+ shell: bash
+ run: mvn $MAVEN_ARGS clean install -DskipTests
+
+ - name: Do the dependency-check:aggregate
+ shell: bash
+ run: mvn $MAVEN_ARGS org.owasp:dependency-check-maven:aggregate
-DossIndexUsername=${{ secrets.OSS_INDEX_USER }} -DossIndexPassword=${{
secrets.OSS_INDEX_TOKEN }} -DnvdApiKey=${{ secrets.NVD_API_KEY }}
Review Comment:
The command line directly exposes sensitive credentials (OSS_INDEX_USER,
OSS_INDEX_TOKEN, NVD_API_KEY) as command-line arguments. While GitHub Actions
masks secrets in logs, command-line arguments may be visible in process
listings or other diagnostic outputs during execution. Consider using
environment variables instead by defining them in an `env:` block and having
the Maven plugin read them through system properties or environment variables.
```suggestion
env:
OSSINDEX_USERNAME: ${{ secrets.OSS_INDEX_USER }}
OSSINDEX_PASSWORD: ${{ secrets.OSS_INDEX_TOKEN }}
NVD_API_KEY: ${{ secrets.NVD_API_KEY }}
run: mvn $MAVEN_ARGS org.owasp:dependency-check-maven:aggregate
```
##########
.github/workflows/vulnerability-check.yml:
##########
@@ -0,0 +1,65 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: vulnerability-check
+
+on:
+ schedule:
+ # Run at UTC 16:00 every week (CST 00:00 AM)
+ - cron: "0 16 * * 0"
+ workflow_dispatch:
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: true
+
+env:
+ MAVEN_OPTS: -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false
-Dmaven.wagon.http.retryHandler.class=standard
-Dmaven.wagon.http.retryHandler.count=3
+ MAVEN_ARGS: --batch-mode --no-transfer-progress
+
+jobs:
+ dependency-check:
+ if: ${{ github.event_name == 'workflow_dispatch' || github.repository ==
'apache/ratis' }}
+ runs-on: ubuntu-latest
+
+ steps:
+ - uses: actions/checkout@v4
+
Review Comment:
There is trailing whitespace at the end of this line. This should be removed
to maintain consistent formatting across the codebase.
```suggestion
```
##########
pom.xml:
##########
@@ -726,6 +726,11 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.owasp</groupId>
+ <artifactId>dependency-check-maven</artifactId>
+ <version>12.1.9</version>
+ </plugin>
Review Comment:
The indentation of this plugin declaration is inconsistent with other plugin
declarations in the file. The opening `<plugin>` tag should use 6 spaces of
indentation to align with other plugins at lines 642-703, and the closing
`</plugin>` tag should also use 6 spaces of indentation instead of 4.
```suggestion
<plugin>
<groupId>org.owasp</groupId>
<artifactId>dependency-check-maven</artifactId>
<version>12.1.9</version>
</plugin>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
