Copilot commented on code in PR #1328: URL: https://github.com/apache/ratis/pull/1328#discussion_r2627498659
########## .github/workflows/vulnerability-check.yml: ########## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: vulnerability-check + +on: + schedule: + # Run at UTC 16:00 every week (CST 00:00) Review Comment: The comment states the cron will run at "UTC 16:00" which would be "CST 00:00", but the cron expression "0 16 * * 0" runs at 16:00 UTC on Sunday (day 0). However, CST (China Standard Time) is UTC+8, so 16:00 UTC would be 00:00 CST the next day (Monday), not Sunday. Consider clarifying the comment to indicate this will run Monday 00:00 CST / Sunday 16:00 UTC, or adjust the schedule if a different day is intended. ```suggestion # Run at 16:00 UTC every Sunday (Monday 00:00 CST) ``` ########## .github/workflows/vulnerability-check.yml: ########## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more Review Comment: The file uses the .yml extension, while other workflow files in the repository use .yaml extension (check.yaml, ci.yaml, post-commit.yaml, repeat-test.yaml). For consistency with the existing codebase, consider renaming this file to vulnerability-check.yaml. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
