ivandika3 commented on code in PR #1334:
URL: https://github.com/apache/ratis/pull/1334#discussion_r2696608101
##########
ratis-docs/src/site/markdown/configurations.md:
##########
@@ -227,6 +227,29 @@ if it fails to receive any RPC responses from this peer
within this specified ti
| **Default** | false
|
+| **Property** | `raft.server.read.read-index.heartbeat.skip.enabled`
|
Review Comment:
@OneSizeFitsQuorum Thanks for the review. I was also grappling with whether
"leadership check" is a better name. However, my reasoning of choosing
"heartbeat" is because we already have a `LeaderStateImpl#checkLeadership` to
decide whether to leader need to step down due to lost majority heartbeats.
`LeaderStateImpl#checkLeadership` does not send heartbeat, it simply checks the
last RPC response time of the majority. Therefore, I picked "heartbeat" to
explicitly mention the RPC that is going to be skipped.
That said, I'm ok if the community decide "leadership-check" is a more
fitting name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
