szetszwo commented on code in PR #1334:
URL: https://github.com/apache/ratis/pull/1334#discussion_r2780495435


##########
ratis-docs/src/site/markdown/configurations.md:
##########
@@ -227,6 +227,29 @@ if it fails to receive any RPC responses from this peer 
within this specified ti
 | **Default**     | false                                                      
           |
 
 
+| **Property**    | `raft.server.read.read-index.heartbeat.skip.enabled`       
         |

Review Comment:
   > What about 
raft.server.read.read-index.leadership-heartbeat-check.skip.enabled?
   
   Sorry for coming late:
   - Since this conf is closely related to 
`raft.server.read.leader.lease.enabled`, they should be next to each other.
   - The default "skip.enabled == false"  is a double negative.
   
   So, how about `raft.server.read.leader.heartbeat-check.enabled` (default is 
true).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to