CRZbulabula commented on PR #1466: URL: https://github.com/apache/ratis/pull/1466#issuecomment-4560798870
Thanks for the review. I have pushed commit 00bd24ef addressing the latest comments: - `GrpcClientRpc` now uses a `MemoizedSupplier<EventLoopGroup>` and exposes the suggested static `create(...)` factory. - The client worker group is initialized lazily and is shut down only when the supplier has been initialized. - `GrpcServicesImpl.Builder#build()` now catches `Throwable`, shuts down any created event-loop groups, and rethrows `RuntimeException` / `Error` directly. - `GrpcServerProtocolClient` and `GrpcStubPool` now require a non-null event-loop group and always configure the Netty channel with it. I also created the JIRAs for the unrelated fixes: - https://issues.apache.org/jira/browse/RATIS-2547 - https://issues.apache.org/jira/browse/RATIS-2548 What would you prefer as the next step for those unrelated fixes: keep them in this PR with the JIRA references, or split them into separate PRs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
