CRZbulabula commented on PR #1466: URL: https://github.com/apache/ratis/pull/1466#issuecomment-4585946369
Rebased this PR on current `master` and pushed `f33b8ebb`. During the rebase, the ReplyFlusher conflict resolved to the upstream RATIS-2547 implementation already merged in #1474, so I kept this PR scoped to the gRPC EventLoopGroup / NettyUtils changes. Additional fix after CI: - Stabilized `TestRaftServerWithGrpc#testRaftServerMetrics` by waiting for the first async reply batch to finish after unblocking the state machine flush, before sending the oversized request used by the request-size metric assertion. Local verification: - `mvn -pl ratis-test -am -Dtest=TestRaftServerWithGrpc#testRaftServerMetrics test` - `mvn -pl ratis-test -am -Dtest=TestRaftServerWithGrpc test` GitHub Actions for `f33b8ebb` are green; coverage is skipped as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
