adoroszlai opened a new pull request, #1493: URL: https://github.com/apache/ratis/pull/1493
## What changes were proposed in this pull request? `maven-compiler-plugin` creates the directory for sources generated by annotation processors (defined by [`<generatedSourcesDirectory>`](https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#generatedSourcesDirectory), with default value `${project.build.directory}/generated-sources/annotations`) even if there are no processors to run. This will be fixed by https://github.com/apache/maven-compiler-plugin/commit/d958a62 in 4.0.0. `ratis-proto` also has sources generated for proto definitions. It is not clear why the empty `generated-sources/annotations` ends up in `ratis-proto.jar` in some environments, but not in others. As a workaround, this PR sets the `<generatedSourcesDirectory>` to `target/generated-sources`, which is created anyway for `ratis-proto`. Also add `<proc>none</proc>` to ensure annotation processors are indeed not used. https://issues.apache.org/jira/browse/RATIS-2572 ## How was this patch tested? `ratis-proto.jar` does not contain `annotations/` for me even without this patch. I hope @OneSizeFitsQuorum, the release manager of 3.2.2, can verify it locally. CI: https://github.com/adoroszlai/ratis/actions/runs/28187818390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
