OneSizeFitsQuorum commented on PR #1493: URL: https://github.com/apache/ratis/pull/1493#issuecomment-4874421809
Verified locally on the `pr-1493` branch with JDK 8 (`-Dmaven.compiler.release=8`). `./mvnw -am -pl :ratis-proto -DskipTests clean verify` — BUILD SUCCESS. After the build, `ratis-proto/target/generated-sources/` contains only `org` (no `annotations/` directory), and `ratis-proto-3.3.0-SNAPSHOT.jar` has no `annotations/` entry (checked via `unzip -l | grep annotations`). Regarding the global effect of `<proc>none</proc>` and `<generatedSourcesDirectory>` in the root `pluginManagement`: I grepped the repo and confirmed no module uses any annotation processor, so disabling processing globally is safe. As a regression check, I also ran `./mvnw -pl :ratis-server,:ratis-client -am -DskipTests clean verify` — all downstream modules (ratis-common, ratis-client, ratis-server-api, ratis-metrics, ratis-server) compiled successfully with no errors. The change works as described and introduces no regressions. +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
