ss77892 commented on code in PR #1534:
URL: https://github.com/apache/ratis/pull/1534#discussion_r3701567306
##########
ratis-client/src/main/java/org/apache/ratis/client/impl/DataStreamClientImpl.java:
##########
@@ -187,6 +187,16 @@ public CompletableFuture<DataStreamReply>
writeAsync(FilePositionCount src, Writ
return writeAsyncImpl(src, src.getCount(), Arrays.asList(options));
}
+ @Override
+ public CompletableFuture<DataStreamReply> commandAsync(ByteBuffer src) {
Review Comment:
What would happen on the client side if it issues two commands without data
in between? As far as I can see, NettyClientReply, when it maps requests,
considers only the stream offset and type, so the second command with the same
offset wouldn't have a ReplyEntry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
