amaliujia commented on code in PR #1534:
URL: https://github.com/apache/ratis/pull/1534#discussion_r3702672148
##########
ratis-client/src/main/java/org/apache/ratis/client/impl/DataStreamClientImpl.java:
##########
@@ -187,6 +187,16 @@ public CompletableFuture<DataStreamReply>
writeAsync(FilePositionCount src, Writ
return writeAsyncImpl(src, src.getCount(), Arrays.asList(options));
}
+ @Override
+ public CompletableFuture<DataStreamReply> commandAsync(ByteBuffer src) {
Review Comment:
Very good call. It seems to me that the first command's `ReplyEntry` will be
used for the second command and the second command's `RequestEntry` won't be
in the map. Anyway it looks like a mess without a handling.
So I instead fail the commands if there is already one at the same stream
offset. After all, we do not expect the caller issue multiple commands at the
same stream offset for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
