[ 
https://issues.apache.org/jira/browse/RATIS-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361706#comment-16361706
 ] 

Tsz Wo Nicholas Sze commented on RATIS-205:
-------------------------------------------

Thanks a lot for the reviews!

# Both update methods have the same logic.  The only have different parameter 
lists.  It is common to use the same name, e.g. see valueOf(..) in 
https://docs.oracle.com/javase/8/docs/api/java/lang/String.html
# For followers, we already update it when receiving from the leader.  For the 
leader, is it the same as #6?
# Sure, let me add a Preconditions check.
# I intend to put it at the end since it is an additional information not 
related to the original protocol.
# Sure, I have added some comments.
# It is for performance.  It may slow down LogAppender if it is updated there.  
The current code updates it in RaftServerImpl.getCommitInfos so that it only 
may slow down the replies.

Here is a new patch: r205_20180213.patch 


> Return commit information to client
> -----------------------------------
>
>                 Key: RATIS-205
>                 URL: https://issues.apache.org/jira/browse/RATIS-205
>             Project: Ratis
>          Issue Type: Sub-task
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Major
>         Attachments: r205_20180205.patch
>
>
> The commit infos should be included in RaftClientReply so that client can get 
> commit infos from the responses of client requests or getInfo.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to