[ 
https://issues.apache.org/jira/browse/RATIS-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361974#comment-16361974
 ] 

Mukul Kumar Singh commented on RATIS-205:
-----------------------------------------

Thanks for updating the patch [~szetszwo], the latest patch looks good to me.
However I feel we can remove the removeCommitInfoFromCache from 
updateCommitIndex, as the cache will be refreshed in 
{{updateFollowerCommitInfos}}. Rest the latest patch looks good to me.

{code}
  protected void updateCommitIndex(long commitIndex) {
    if (follower.updateCommitIndex(commitIndex)) {
      server.removeCommitInfoFromCache(getFollowerId());
    }
  }
{code}

> Return commit information to client
> -----------------------------------
>
>                 Key: RATIS-205
>                 URL: https://issues.apache.org/jira/browse/RATIS-205
>             Project: Ratis
>          Issue Type: Sub-task
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Major
>         Attachments: r205_20180213.patch
>
>
> The commit infos should be included in RaftClientReply so that client can get 
> commit infos from the responses of client requests or getInfo.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to