[
https://issues.apache.org/jira/browse/RATIS-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413632#comment-16413632
]
Tsz Wo Nicholas Sze commented on RATIS-176:
-------------------------------------------
> By moving the check, in LogAppender.addEntry in the server, what happens is,
> createRequest fails , the sender is stopped and it triggers an re-election .
> ...
Good point! Then, please
- remove RaftLog.isValidLogEntry. Just check the size in RaftLog.append.
- We probably should keep using StateMachineException so that it will propagate
to the client? Let's use RaftLogIOException instead of IOException then.
> Log Appender should throw an Exception in case append entry size exceeds the
> maxBufferSize configured
> ------------------------------------------------------------------------------------------------------
>
> Key: RATIS-176
> URL: https://issues.apache.org/jira/browse/RATIS-176
> Project: Ratis
> Issue Type: Bug
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Minor
> Attachments: RATIS-176.001.patch
>
>
> LogAppender while adding append entry in LogEntryBuffer, checks whether the
> total allocated for all entries does not exceed the maxBufferSize allocated.
> In case, the size exceeds the limit ,entries are not added to the buffer but
> no exception is thrown . This case needs to be handled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
