[
https://issues.apache.org/jira/browse/RATIS-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415566#comment-16415566
]
Tsz Wo Nicholas Sze commented on RATIS-176:
-------------------------------------------
[~shashikant], thanks for the update. Some comments:
- In RaftLog.append, remove the LOG.info. The message is not useful.
- Add a constructor RaftLogIOException(String) so that we don't have to create
an IOException.
- As mentioned previously, please move the new test to ratis-server module
instead of ratis-example. Just add the new test to RaftExceptionBaseTest.
> Log Appender should throw an Exception in case append entry size exceeds the
> maxBufferSize configured
> ------------------------------------------------------------------------------------------------------
>
> Key: RATIS-176
> URL: https://issues.apache.org/jira/browse/RATIS-176
> Project: Ratis
> Issue Type: Bug
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Minor
> Attachments: RATIS-176.001.patch, RATIS-176.002.patch
>
>
> LogAppender while adding append entry in LogEntryBuffer, checks whether the
> total allocated for all entries does not exceed the maxBufferSize allocated.
> In case, the size exceeds the limit ,entries are not added to the buffer but
> no exception is thrown . This case needs to be handled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
