[ https://issues.apache.org/jira/browse/RATIS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431646#comment-16431646 ]
Hadoop QA commented on RATIS-224: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 23s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 19s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 44m 4s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 46s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 22s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 5s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}302m 6s{color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red}125m 48s{color} | {color:red} root in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red}125m 48s{color} | {color:red} root in the patch failed. {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 23s{color} | {color:orange} root: The patch generated 40 new + 212 unchanged - 27 fixed = 252 total (was 239) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 36s{color} | {color:red} root generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 61m 38s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 10s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}545m 28s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-04-09 | | JIRA Issue | RATIS-224 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12918213/r224_20180410.patch | | Optional Tests | asflicense javac javadoc unit findbugs checkstyle compile | | uname | Linux fe1c987b9a25 3.13.0-141-generic #190-Ubuntu SMP Fri Jan 19 12:52:38 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh | | git revision | master / 00f64b4 | | Default Java | 1.8.0_162 | | mvninstall | https://builds.apache.org/job/PreCommit-RATIS-Build/174/artifact/out/patch-mvninstall-root.txt | | compile | https://builds.apache.org/job/PreCommit-RATIS-Build/174/artifact/out/patch-compile-root.txt | | javac | https://builds.apache.org/job/PreCommit-RATIS-Build/174/artifact/out/patch-compile-root.txt | | checkstyle | https://builds.apache.org/job/PreCommit-RATIS-Build/174/artifact/out/diff-checkstyle-root.txt | | javadoc | https://builds.apache.org/job/PreCommit-RATIS-Build/174/artifact/out/diff-javadoc-javadoc-root.txt | | unit | https://builds.apache.org/job/PreCommit-RATIS-Build/174/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/174/testReport/ | | modules | C: ratis-common ratis-server ratis-grpc U: . | | Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/174/console | | Powered by | Apache Yetus 0.5.0 http://yetus.apache.org | This message was automatically generated. > In RpcTimeout, it should shut down the scheduler if there is no tasks > --------------------------------------------------------------------- > > Key: RATIS-224 > URL: https://issues.apache.org/jira/browse/RATIS-224 > Project: Ratis > Issue Type: Improvement > Reporter: Tsz Wo Nicholas Sze > Assignee: Tsz Wo Nicholas Sze > Priority: Minor > Attachments: r224_20180410.patch > > > Currently, RpcTimeout tracks the number of users. When the number of users > becomes zero, it should shut down the scheduler . > Instead of tracking users, it is better to try the number of tasks. When the > number of tasks becomes zero, it should shut down the scheduler. -- This message was sent by Atlassian JIRA (v7.6.3#76005)