[
https://issues.apache.org/jira/browse/RATIS-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568776#comment-16568776
]
Tsz Wo Nicholas Sze commented on RATIS-288:
-------------------------------------------
[~elserj], thanks for working on the pom files. It is great if you can improve
the build.
What mvn commands should be run after the change? I tried
{code}
mvn clean package -DskipTests
{code}
but it failed.
{code}
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check
(default) on project ratis-proto-shaded: Too many files with unapproved
license: 365 See RAT report in:
/Users/szetszwo/ratis/apache-ratis/ratis-proto-shaded/target/rat.txt -> [Help 1]
{code}
> Pom cleanup/simplification
> --------------------------
>
> Key: RATIS-288
> URL: https://issues.apache.org/jira/browse/RATIS-288
> Project: Ratis
> Issue Type: Improvement
> Components: build
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Minor
> Attachments: RATIS-288.005.patch
>
>
> I'm noticing quite a bit of over-complication in the build, mostly around
> ratis-proto-shaded. From what I can tell in the git history, this is holdover
> from quite some time ago (when the module itself was introduced).
> Some weird things I see:
> * Everything being marked as optional
> * Explicit scope=compile being listed (this is the default)
> * Inheriting all configuration from the netty-all pom (not sure why we'd
> want this)
> * Recompilation of source files included in ratis-proto-shaded (shade-plugin
> can do this already)
> My only guess is that some of this was to support the {{skipShade}} option. I
> think I can halve the amount of time for the ratis-proto-shaded model, and
> still support a workflow that will let folks skip re-compilation if they
> haven't changed the protobufs
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
