[ 
https://issues.apache.org/jira/browse/RATIS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598763#comment-16598763
 ] 

Mukul Kumar Singh commented on RATIS-300:
-----------------------------------------

Thanks a lot for working on this [~szetszwo] and for the followup jira's. The 
patch looks really good to me. I have some minor comments on this patch.

1) LeaderElectionTests,108: serveRaftServerImplr -> serveRaftServerImpl
2) RaftServerProxy,51, unused import
3) RaftServerProxy:325, if there is an exception, we should remove the new impl 
from the impl map ?
4) RaftServerTestUtil:30, unused import.


> Support multiple RaftServerImpl in RaftServerProxy
> --------------------------------------------------
>
>                 Key: RATIS-300
>                 URL: https://issues.apache.org/jira/browse/RATIS-300
>             Project: Ratis
>          Issue Type: Sub-task
>          Components: server
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Major
>              Labels: ozone
>         Attachments: r300_20180822.patch
>
>
> Currently, there is only one RaftServerImpl object in a RaftServerProxy 
> object.  This JIRA is to support multiple RaftServerImpl objects in a 
> RaftServerProxy object in order to support mult-raft.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to