[
https://issues.apache.org/jira/browse/RATIS-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622543#comment-16622543
]
Hadoop QA commented on RATIS-316:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 26 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 6s{color}
| {color:red} root generated 7 new + 85 unchanged - 0 fixed = 92 total (was 85)
{color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
1m 25s{color} | {color:orange} root: The patch generated 58 new + 4752
unchanged - 62 fixed = 4810 total (was 4814) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 7 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
18s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
39s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 4s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 12s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerSlownessDetection |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-09-20
|
| JIRA Issue | RATIS-316 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12940647/RATIS-316.003.patch |
| Optional Tests | asflicense javac javadoc unit xml compile findbugs
checkstyle cc |
| uname | Linux 60fe7adeb8bb 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 523fb63 |
| Default Java | 1.8.0_181 |
| javac |
https://builds.apache.org/job/PreCommit-RATIS-Build/354/artifact/out/diff-compile-javac-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/354/artifact/out/diff-checkstyle-root.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-RATIS-Build/354/artifact/out/whitespace-tabs.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/354/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/354/testReport/ |
| modules | C: ratis-proto . ratis-assembly ratis-client ratis-common
ratis-examples ratis-grpc ratis-hadoop ratis-hadoop-shaded ratis-logservice
ratis-netty ratis-replicated-map ratis-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/354/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Centralize shaded thirdparty dependencies in a single artifact
> --------------------------------------------------------------
>
> Key: RATIS-316
> URL: https://issues.apache.org/jira/browse/RATIS-316
> Project: Ratis
> Issue Type: Improvement
> Components: build
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Major
> Attachments: RATIS-316.003.patch
>
>
> After the changes in RATIS-288, developers may find that their IDEs are
> complaining about dependencies that we bundle in ratis-proto-shaded as not
> being "found".
> This is understandable because IDEs typically aren't smart enough to follow
> the maven-shade-plugin and unravel the relocation that's happening.
> The easiest solution for this is to make an artifact for our "thirdparty"
> dependencies that has its own release schedule. The "core" of Ratis can then
> depend on this artifact and the relocated dependencies in the well-known
> location (fix the IDE errors). Additionally, this will give us a bit more
> flexibility in upgrading to newer versions of these dependencies without
> having to re-release Ratis (e.g. if there is a CVE on Netty, we can make a
> new release of ratis-thirdparty without re-releasing Ratis just for that
> change).
> We could move this to a separate git repo, but it's easy enough to just leave
> this is a sub-directory of ratis.git. I don't have strong feelings either way.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
