[
https://issues.apache.org/jira/browse/RATIS-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622184#comment-16622184
]
Hadoop QA commented on RATIS-316:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color}
| {color:red} RATIS-316 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.5.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | RATIS-316 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12939599/RATIS-316.001.patch |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/352/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Centralize shaded thirdparty dependencies in a single artifact
> --------------------------------------------------------------
>
> Key: RATIS-316
> URL: https://issues.apache.org/jira/browse/RATIS-316
> Project: Ratis
> Issue Type: Improvement
> Components: build
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Major
> Attachments: RATIS-316.001.patch, RATIS-316.002.patch
>
>
> After the changes in RATIS-288, developers may find that their IDEs are
> complaining about dependencies that we bundle in ratis-proto-shaded as not
> being "found".
> This is understandable because IDEs typically aren't smart enough to follow
> the maven-shade-plugin and unravel the relocation that's happening.
> The easiest solution for this is to make an artifact for our "thirdparty"
> dependencies that has its own release schedule. The "core" of Ratis can then
> depend on this artifact and the relocated dependencies in the well-known
> location (fix the IDE errors). Additionally, this will give us a bit more
> flexibility in upgrading to newer versions of these dependencies without
> having to re-release Ratis (e.g. if there is a CVE on Netty, we can make a
> new release of ratis-thirdparty without re-releasing Ratis just for that
> change).
> We could move this to a separate git repo, but it's easy enough to just leave
> this is a sub-directory of ratis.git. I don't have strong feelings either way.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
