[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797075#comment-16797075
]
Tsz Wo Nicholas Sze commented on RATIS-498:
-------------------------------------------
Thanks, [~hanishakoneru]. I have the following comments so far.
- In GrpcLogAppender.installSnapshot(firstAvailableLogTermIndex), it should
call onCompleted() after onNext(..) and, if there is an exception, call
onError(..).
- In InstallSnapshotResult, let's rename INSTALL_SNAPSHOT_IN_PROGRESS to
IN_PROGRESS and SNAPSHOT_ALREADY_INSTALLED to ALREADY_INSTALLED.
-* BTW, is SNAPSHOT_ALREADY_INSTALLED the same as SUCCESS?
- Let's remove InstallSnapshotResponseHandler.isNotifyOnly. We may use
installSnapshotEnabled to tell whether the command is "install" or "notify".
> Notify Follower to Install Snapshot through state machine
> ---------------------------------------------------------
>
> Key: RATIS-498
> URL: https://issues.apache.org/jira/browse/RATIS-498
> Project: Ratis
> Issue Type: New Feature
> Components: server
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Attachments: RATIS-498+RATIS-505.patch, RATIS-498.000.patch,
> RATIS-498.001.patch, RATIS-498.002.patch
>
>
> When a lagging Follower wants to catch up with the Leader, and the Leader
> only has logs with start index greater than the Followers's last log index,
> then the leader sends an InstallSnapshotRequest to the the Follower.
> The aim of this Jira is to allow State Machine to decouple snapshot
> installation from the Ratis server. When Leader does not have the logs to get
> the Follower up to speed, it should notify the Follower to install a snapshot
> (if install snapshot through Log Appender is disabled). The Follower in turn
> notifies its state machine that a snapshot is required to catch up with the
> leader.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
