[
https://issues.apache.org/jira/browse/RATIS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846820#comment-16846820
]
Josh Elser commented on RATIS-520:
----------------------------------
Thanks for the patch, Vlad. Two requests
{code:java}
private String host = "localhost";
+ private boolean _host_set = false;
{code}
What about just defaulting these variables (\{{host}} in this case) to {{null}}
and then using the null check to implement {{isHostSet()}} and the rest? I feel
like the default values you added in {{Constants.java}} encapsulate this logic
better than here in {{ServerOpts}}.
{noformat}
+ * The base configuration is defined in logservice.xml file,
+ * which is expected to reside in a class path.
{noformat}
Can you update {{README.md}} to call this out? I think it's important for
people to know how to create this file (maybe we could have a
{{logservice-example.xml}} file in the top of the {{ratis-logservice}} module?)
so they can modify/tweak it on their own.
After this is in place, we'll want to update the Docker/Vagrant automation to
be able to pick this up, but that doesn't need to be done here/now.
> [Configuration] Unify configuration across client and server code
> -----------------------------------------------------------------
>
> Key: RATIS-520
> URL: https://issues.apache.org/jira/browse/RATIS-520
> Project: Ratis
> Issue Type: Sub-task
> Affects Versions: 0.4.0
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Priority: Major
> Fix For: 0.4.0
>
> Attachments: RATIS-520-v1.patch
>
>
> Configuration of implementation specific details inside of Ratis itself need
> to be created as they presently are static. The ability to configure them on
> the fly for administration of the system is a must.
> Work breakdown:
> RATIS-477 has some implementation of LogStateMachine configuration.
> Need a method to configure the MetadataStateMachine and LogStateMachine(s)
> with LogService-level configuration. For example:
> Command-line arguments to specify configuration key=values
> Configuration file which can be specified
> Something else… (with justification why chosen)
> Potentially, can the system be dynamically reconfigured.
> Method of configuring the system must be clearly documented
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
