[
https://issues.apache.org/jira/browse/RATIS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851388#comment-16851388
]
Hadoop QA commented on RATIS-520:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 8m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
15s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
7s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 15s{color} | {color:orange} root: The patch generated 51 new + 47 unchanged
- 2 fixed = 98 total (was 49) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 51 line(s) that end in whitespace. Use
git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 29m 12s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 47m 40s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.server.TestMetaServer |
| | ratis.logservice.TestLogServiceWithNetty |
| | ratis.logservice.TestLogServiceWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithNetty |
| | ratis.grpc.TestRaftStateMachineExceptionWithGrpc |
| | ratis.netty.TestRaftReconfigurationWithNetty |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.grpc.TestWatchRequestWithGrpc |
| | ratis.grpc.TestInstallSnapshotWithGrpc |
| | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
| | ratis.netty.TestRaftStateMachineExceptionWithNetty |
| | ratis.grpc.TestStateMachineShutdownWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2019-05-29
|
| JIRA Issue | RATIS-520 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12970249/RATIS-520-v2.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile xml |
| uname | Linux c8ec99244b50 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / b98fac8 |
| maven | version: Apache Maven 3.6.0
(97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) |
| Default Java | 1.8.0_212 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/799/artifact/out/diff-checkstyle-root.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-RATIS-Build/799/artifact/out/whitespace-eol.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/799/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/799/testReport/ |
| Max. process+thread count | 1412 (vs. ulimit of 5000) |
| modules | C: ratis-common ratis-logservice U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/799/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> [Configuration] Unify configuration across client and server code
> -----------------------------------------------------------------
>
> Key: RATIS-520
> URL: https://issues.apache.org/jira/browse/RATIS-520
> Project: Ratis
> Issue Type: Sub-task
> Affects Versions: 0.4.0
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Priority: Major
> Fix For: 0.4.0
>
> Attachments: RATIS-520-v1.patch, RATIS-520-v2.patch
>
>
> Configuration of implementation specific details inside of Ratis itself need
> to be created as they presently are static. The ability to configure them on
> the fly for administration of the system is a must.
> Work breakdown:
> RATIS-477 has some implementation of LogStateMachine configuration.
> Need a method to configure the MetadataStateMachine and LogStateMachine(s)
> with LogService-level configuration. For example:
> Command-line arguments to specify configuration key=values
> Configuration file which can be specified
> Something else… (with justification why chosen)
> Potentially, can the system be dynamically reconfigured.
> Method of configuring the system must be clearly documented
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
