[
https://issues.apache.org/jira/browse/RATIS-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848796#comment-16848796
]
Mukul Kumar Singh commented on RATIS-566:
-----------------------------------------
Thanks for working on this [~szetszwo]. The patch generally looks good to me.
Some minor comments as following.
a) GrpcClientProtocolService:326, can we add an assert that we only see one
group on one stream observer. i.e this compareAndSet returns true only once and
false otherwise and all the requests are for the same group.
> OrderedStreamObservers#closeAllExisting should close the streams writing to
> certain group id only
> -------------------------------------------------------------------------------------------------
>
> Key: RATIS-566
> URL: https://issues.apache.org/jira/browse/RATIS-566
> Project: Ratis
> Issue Type: Bug
> Components: gRPC
> Affects Versions: 0.3.0
> Reporter: Mukul Kumar Singh
> Assignee: Tsz Wo Nicholas Sze
> Priority: Major
> Attachments: r566_20190524.patch
>
>
> OrderedStreamObservers#closeAllExisting currently closes all the stream
> observers on notifyNotLeader. However this can lead to stream observers for a
> different groups to be closed. This can cause the client to retry
> unnecessarily. Not leader should only close the stream observers for a
> certain groupid.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
