[
https://issues.apache.org/jira/browse/RATIS-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850530#comment-16850530
]
Tsz Wo Nicholas Sze commented on RATIS-566:
-------------------------------------------
Thanks [~msingh]. Although it is impossible to have different groups in the
current client implementation, it is good to assert. Here is a new patch:
r566_20190529.patch:
> OrderedStreamObservers#closeAllExisting should close the streams writing to
> certain group id only
> -------------------------------------------------------------------------------------------------
>
> Key: RATIS-566
> URL: https://issues.apache.org/jira/browse/RATIS-566
> Project: Ratis
> Issue Type: Bug
> Components: gRPC
> Affects Versions: 0.3.0
> Reporter: Mukul Kumar Singh
> Assignee: Tsz Wo Nicholas Sze
> Priority: Major
> Attachments: r566_20190524.patch, r566_20190529.patch
>
>
> OrderedStreamObservers#closeAllExisting currently closes all the stream
> observers on notifyNotLeader. However this can lead to stream observers for a
> different groups to be closed. This can cause the client to retry
> unnecessarily. Not leader should only close the stream observers for a
> certain groupid.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
