[
https://issues.apache.org/jira/browse/RATIS-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848820#comment-16848820
]
Mukul Kumar Singh commented on RATIS-568:
-----------------------------------------
Thanks for working on this [~szetszwo]. The patch generally looks good to me.
Some minor comments
a) GrpcClientProtocolService, responseCompleted can be called in all the cases
as we should send replies for all the requests which have been processed.
b) GrpcClientProtocolService:116, so should call onCompleted to complete the
client stream observer as well.
> Server sliding window should fail out of order requests on close
> ----------------------------------------------------------------
>
> Key: RATIS-568
> URL: https://issues.apache.org/jira/browse/RATIS-568
> Project: Ratis
> Issue Type: Bug
> Components: gRPC
> Reporter: Lokesh Jain
> Assignee: Tsz Wo Nicholas Sze
> Priority: Major
> Attachments: r568_20190524.patch
>
>
> Currently SlidingWindow does not fail the out of order requests on close. The
> out of order requests are not processed and are therefore never removed from
> the queue leading to memory leak. Further OrderedRequestStreamObserver should
> be removed from the orderedStreamObservers map on error or completion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
